Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various visuals of playlist beatmap panels #28947

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 19, 2024

Supersedes #28907.

  • Fix border being fat
  • Fix thumbnail not masking correctly
  • Fix background layer not being correctly fit to the panel
  • Dim the main background on hover
  • Minor tweaks to dimming and sizing
Before After
osu! 2024-07-19 at 10 18 35 osu! 2024-07-19 at 10 20 25

Supersedes ppy#28907.

- Fix border being fat
- Fix thumbnail not masking correctly
- Fix background layer not being correctly fit to the panel
- Dim the main background on hover
- Minor tweaks to dimming
@SupDos
Copy link
Contributor

SupDos commented Jul 19, 2024

Just wanted to mention that the resizing of the difficulty icon might make it slightly harder for people to quickly mouse over and aim at it to see the difficulty settings for it due to the size change, but could just be a silly nitpick

image

@smoogipoo smoogipoo merged commit ad564f3 into ppy:master Jul 19, 2024
6 of 11 checks passed
@peppy
Copy link
Member Author

peppy commented Jul 19, 2024

Just wanted to mention that the resizing of the difficulty icon might make it slightly harder for people to quickly mouse over and aim at it to see the difficulty settings for it due to the size change, but could just be a silly nitpick

image

it's still huge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants